fix(amazonq): disable SageMakerUnifiedStudio for show logs #7747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abhraina-aws
force-pushed
the
enable-show-logs-1
branch
from
2cdf8cd to
5d7eb35
Compare
abhraina-aws
changed the title
ashishrp-aws
previously approved these changes
Jul 24, 2025
laileni-aws
changed the title
laileni-aws
reviewed
Jul 24, 2025
packages/amazonq/package.json
Outdated
| { | ||
| "command": "aws.amazonq.showLogs", | ||
| "when": "view == aws.amazonq.AmazonQChatView", | ||
| "when": "view == aws.amazonq.AmazonQChatView && !aws.isSageMakerUnifiedStudio", |
Contributor
There was a problem hiding this comment.
"when": "view == aws.amazonq.AmazonQChatView && !aws.isSageMakerUnifiedStudio && aws.codewhisperer.connected"
laileni-aws
reviewed
Jul 24, 2025
packages/amazonq/package.json
Outdated
| "title": "%AWS.command.codewhisperer.showLogs%", | ||
| "category": "%AWS.amazonq.title%", | ||
| "enablement": "aws.codewhisperer.connected" | ||
| "enablement": "aws.codewhisperer.connected && !aws.isSageMakerUnifiedStudio" |
Contributor
There was a problem hiding this comment.
We don't need this If we apply above suggestion.
laileni-aws
previously approved these changes
Jul 24, 2025
abhraina-aws
dismissed stale reviews from laileni-aws and ashishrp-aws
via
57ed101
abhraina-aws
force-pushed
the
enable-show-logs-1
branch
from
5d7eb35 to
57ed101
Compare
laileni-aws
reviewed
Jul 24, 2025
| { | ||
| "command": "aws.amazonq.showLogs", | ||
| "when": "view == aws.amazonq.AmazonQChatView", | ||
| "when": "!aws.isSageMakerUnifiedStudio", |
Contributor
There was a problem hiding this comment.
nit:
view == aws.amazonq.AmazonQChatView
This can stay! as we dont want to show this for other view may be for code issues!
Contributor
Author
There was a problem hiding this comment.
Having this doesn't show the log on login window. I tested that configuration also.
laileni-aws
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Added another code setting for show logs.
Solution
Added another code setting for show logs.
feature/xbranches will not be squash-merged at release time.