Skip to content

fix(amazonq): early stop pagination requests when user decision is made #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025
Merged

fix(amazonq): early stop pagination requests when user decision is made #7759

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81da6b1
fix: early stop pagination requests
leigaol Jul 24, 2025
8449b3d
also fix the codewhispererTotalShownTime in telemetry
leigaol Jul 24, 2025
565e084
add session display time for reject
leigaol Jul 24, 2025
f48f56f
reject case display time
leigaol Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/amazonq/src/app/inline/recommendationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
import { CancellationToken, InlineCompletionContext, Position, TextDocument } from 'vscode'
import { LanguageClient } from 'vscode-languageclient'
import { SessionManager } from './sessionManager'
import { AuthUtil, CodeWhispererStatusBarManager } from 'aws-core-vscode/codewhisperer'
import { AuthUtil, CodeWhispererStatusBarManager, vsCodeState } from 'aws-core-vscode/codewhisperer'
import { TelemetryHelper } from './telemetryHelper'
import { ICursorUpdateRecorder } from './cursorUpdateManager'
import { globals, getLogger } from 'aws-core-vscode/shared'
Expand Down Expand Up @@ -183,6 +183,11 @@ export class RecommendationService {
request,
token
)
// when pagination is in progress, but user has already accepted or rejected an inline completion
// then stop pagination
if (this.sessionManager.getActiveSession() === undefined || vsCodeState.isCodeWhispererEditing) {
break
}
this.sessionManager.updateSessionSuggestions(result.items)
nextToken = result.partialResultToken
}
Expand Down
Loading