Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Jul 25, 2025

Problem

In VSC, we check that the metric name must be in aws-toolkit-common before emitting the metric.

Therefore when we want to add a new metric, the current process is:

  1. Add new metric in aws-toolkit-common
  2. Wait for version to increment (~1 hour)
  3. Bump up toolkit-common version in VSC repo
  4. Wait for next VSC release (up to 1 week)

Only after steps 1-4, will we be actually emitting the new metric.

JB, VS, and Eclipse do not have this dependency, and assume Flare is the source of truth for metrics

Solution

In VSC, Flare is now the source of truth for metrics instead of depending on aws-toolkit-common


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner July 25, 2025 19:10
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@chungjac chungjac changed the title fix: flare is now source of truth for metrics fix(telemetry): flare is now source of truth for metrics Jul 25, 2025
@chungjac chungjac changed the title fix(telemetry): flare is now source of truth for metrics telemetry(amazonq): flare is now source of truth for metrics Jul 25, 2025
@chungjac chungjac closed this Jul 25, 2025
@chungjac chungjac reopened this Jul 25, 2025
@chungjac
Copy link
Contributor Author

chungjac commented Jul 25, 2025

/retryBuilds

@chungjac chungjac closed this Jul 25, 2025
@chungjac chungjac reopened this Jul 25, 2025
@chungjac chungjac marked this pull request as draft July 25, 2025 20:22
@chungjac chungjac marked this pull request as ready for review July 28, 2025 18:12
@chungjac chungjac merged commit 3b85269 into aws:master Jul 28, 2025
57 of 72 checks passed
@chungjac chungjac deleted the telemetry-check branch October 8, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants