feat(stepfunctions): Handling newExecution and editStateMachine #7779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zelzhou
reviewed
Jul 29, 2025
packages/core/src/stepFunctions/executionDetails/handleMessage.ts
Outdated
Show resolved
Hide resolved
zelzhou
reviewed
Jul 29, 2025
anthonyting
suggested changes
Jul 29, 2025
Contributor
anthonyting
left a comment
anthonyting
left a comment
There was a problem hiding this comment.
Can you fix the PR name? It's failing the lint-commits check.
packages/core/src/stepFunctions/executionDetails/handleMessage.ts
Outdated
Show resolved
Hide resolved
packages/core/src/stepFunctions/executionDetails/handleMessage.ts
Outdated
Show resolved
Hide resolved
l0minous
changed the title
|
zelzhou
approved these changes
Jul 30, 2025
anthonyting
suggested changes
Jul 31, 2025
packages/core/src/stepFunctions/executionDetails/handleMessage.ts
Outdated
Show resolved
Hide resolved
packages/core/src/stepFunctions/commands/downloadStateMachineDefinition.ts
Show resolved
Hide resolved
l0minous
force-pushed
the
ConnectButtons
branch
2 times, most recently
from
2ab27f9 to
b68fa97
Compare
anthonyting
suggested changes
Jul 31, 2025
anthonyting
approved these changes
Jul 31, 2025
laileni-aws
reviewed
Aug 1, 2025
| // Parsing execution ARN to get state machine info | ||
| const parsedArn = parseExecutionArnForStateMachine(context.executionArn) | ||
| if (!parsedArn) { | ||
| throw new Error(`Invalid execution ARN format: ${context.executionArn}`) |
Contributor
There was a problem hiding this comment.
nit:
Its better to mention StepFunctions in front of logs as we do have many services in AWS Toolkit. I guess this will ease to debug issues.
laileni-aws
approved these changes
Aug 1, 2025
bywang56
merged commit 70af2bd
into
aws:feature/stepfunctions-execution
45 of 48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the New Execution and Edit State Machine Buttons in Execution Details don't work
Solution
New Execution button now opens a new input webview
Edit State Machine launches Workflow Studio
Added message handling for new execution and edit state machine
Refactoring in utils
Verification
feature/xbranches will not be squash-merged at release time.