Skip to content

fix(amazonq): bring back the removal of extra) ] } ' " after inline completion acceptance #7783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

fix(amazonq): bring back the removal of extra) ] } ' " after inline completion acceptance #7783

merged 2 commits into from
Jul 31, 2025

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jul 29, 2025 •
edited
Loading

Problem

close_bracket_bug.mov

When an inline completion is accepted, there can be extra ) ] } ' " that breaks the syntax.

Solution

fix_closing_bracket.mov

Bring back old code that was used to remove the extra ) ] } ' " .

closing_._fix.mov

Ref: https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/core/src/codewhisperer/util/closingBracketUtil.ts

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner July 29, 2025 02:02
@github-actions
Copy link

github-actions bot commented Jul 29, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol marked this pull request as draft July 29, 2025 02:06
@leigaol leigaol marked this pull request as ready for review July 29, 2025 02:27
@bywang56 bywang56 merged commit a41fde3 into aws:master Jul 31, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leigaol @Will-ShaoHua @bywang56