-
Notifications
You must be signed in to change notification settings - Fork 743
fix(amazonq): update LSP client info name for sagemaker unified studio #7786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c90d0d0
fix(amazonq): update LSP client info name for sagemaker unified studio
parameja1 e905d4d
Merge branch 'aws:master' into master
parameja1 8838b61
update return type for getClientName
parameja1 022c81c
Merge branch 'aws:master' into master
parameja1 cee9380
update isSageMaker logic to use env vars properly and add unit tests
parameja1 aa5405d
Merge branch 'aws:master' into master
parameja1 f52f477
Merge branch 'aws:master' into master
parameja1 8fe741e
fix(amazonq): add comment to smus util method
parameja1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ import { mapMetadata, MetadataObj } from './telemetryLogger' | |
| import { Result } from './telemetry.gen' | ||
| import { MetricDatum } from './clienttelemetry' | ||
| import { isValidationExemptMetric } from './exemptMetrics' | ||
| import { isAmazonQ, isCloud9, isSageMaker } from '../../shared/extensionUtilities' | ||
| import { isAmazonQ, isCloud9, isSageMaker, isSageMakerUnifiedStudio } from '../../shared/extensionUtilities' | ||
| import { isUuid, randomUUID } from '../crypto' | ||
| import { ClassToInterfaceType } from '../utilities/tsUtils' | ||
| import { asStringifiedStack, FunctionEntry } from './spans' | ||
|
|
@@ -481,3 +481,15 @@ export function withTelemetryContext(opts: TelemetryContextArgs) { | |
| }) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Used to identify the q client info and send the respective origin parameter from LSP to invoke Maestro service at CW API level | ||
| * | ||
| * Returns default value of vscode appName or AmazonQ-For-SMUS-CE in case of a sagemaker unified studio environment | ||
| */ | ||
| export function getClientName() { | ||
| if (isSageMaker() && isSageMakerUnifiedStudio()) { | ||
|
||
| return 'AmazonQ-For-SMUS-CE' | ||
| } | ||
| return env.appName | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.