Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jul 29, 2025

Problem

There is a bug in VS Code inline completion API, when hitting Enter, the context.triggerKind is Invoke (0)
when hitting other keystrokes, the context.triggerKind is Automatic (1)
we should only mark option + C as manual trigger Invoke(0)

Solution

Use timestamp to decide what is manual trigger and what is auto trigger.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner July 29, 2025 23:41
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol changed the title fix: correct the is auto trigger boolean flag fix(amazonq): correct the is auto trigger boolean flag Jul 29, 2025
@leigaol leigaol changed the title fix(amazonq): correct the is auto trigger boolean flag fix(amazonq): correct the isAutoTrigger boolean flag Jul 30, 2025
@tsmithsz tsmithsz closed this Jul 31, 2025
@tsmithsz tsmithsz reopened this Jul 31, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@bywang56 bywang56 merged commit 54dbec8 into aws:master Jul 31, 2025
45 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants