-
Notifications
You must be signed in to change notification settings - Fork 746
feat(amazonq): enable displayFindings tool #7799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
laileni-aws
reviewed
Aug 1, 2025
laileni-aws
previously approved these changes
Aug 1, 2025
laileni-aws
previously approved these changes
Aug 1, 2025
tsmithsz
reviewed
Aug 1, 2025
| ) | ||
| } | ||
|
|
||
| public mergeIssuesDisplayFindings(newIssues: AggregatedCodeScanIssue, fromQCA: boolean) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add tests for this?
laileni-aws
approved these changes
Aug 4, 2025
tsmithsz
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to enable and support findings coming in from the displayFindings tool
Also - Agentic scans are supposed to use the CodeAnalysisScope of AGENTIC, which needed to be added
Solution
Set feature flag for displayFindings to be true
Listen for displayFindings messageId from FLARE similarly to how is being done for CodeReview tool.
Treat displayFindings findings and CodeReview findings separately, so they do not overwrite one another.
feature/xbranches will not be squash-merged at release time.