fix(sagemaker): Reduce number of reconnect retries #7827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
aws-asolidu
approved these changes
Aug 6, 2025
laileni-aws
approved these changes
Aug 6, 2025
leigaol
approved these changes
Aug 13, 2025
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
leigaol
added a commit
to leigaol/aws-toolkit-vscode
that referenced
this pull request
Aug 19, 2025
* chore: merge release candidate version rc-20250815 (aws#7916) ## Problem This merges the released changes for rc-20250815 into main. MCM-132479224 ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Lei Gao <[email protected]> Co-authored-by: Na Yue <[email protected]> Co-authored-by: Will Lo <[email protected]> Co-authored-by: Aidan Ton <[email protected]> Co-authored-by: atontb <[email protected]> * fix(sagemaker): Reduce number of reconnect retries (aws#7827) ## Problem When a connection to a remote space is severed, the extension will attempt to reconnect up to 60 times. Each reconnect attempt opens the Space Details page in a new browser tab. Opening up to 60 new tabs is a poor user experience. ## Solution We change the maximum number of retries to 8. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Newton Der <[email protected]> * fix(amazonq): do not auto trigger if the ongoing typeahead does not match (aws#7924) ## Problem Bug: When inline suggestion is active but user types a character that does not match the typeahead, this typing event triggered a inline completion API call that eventually did not manage to display suggestion on screen, which eventually reported as rejected completions. ## Solution Previously, before Flare migration, we had this design: https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/amazonq/src/app/inline/activation.ts#L108 Auto trigger will be disabled if at that moment the suggestion is visible. Under the previous design, the first character that does not match the typeahead will not make a new auto trigger, it simply rejects the current inline completion. This PR is to bring back the old design. It is not customer facing, hence no change log. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: tsmithsz <[email protected]> Co-authored-by: Na Yue <[email protected]> Co-authored-by: Will Lo <[email protected]> Co-authored-by: Aidan Ton <[email protected]> Co-authored-by: atontb <[email protected]> Co-authored-by: Newton Der <[email protected]> Co-authored-by: Newton Der <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a connection to a remote space is severed, the extension will attempt to reconnect up to 60 times. Each reconnect attempt opens the Space Details page in a new browser tab. Opening up to 60 new tabs is a poor user experience.
Solution
We change the maximum number of retries to 8.
feature/xbranches will not be squash-merged at release time.