-
Notifications
You must be signed in to change notification settings - Fork 694
feat(telemetry): add IAM telemetry #7830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuxianrz
wants to merge
16
commits into
aws:feature/flare-mega
Choose a base branch
from
liramon1:feature/telemetry
base: feature/flare-mega
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−3
Open
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
996497e
fix: add codeWhispererNodes error
yuxianrz 324c47b
add sts management and mfa
yuxianrz b7a546d
fix merging disconnect
yuxianrz b0e23e1
fix eslint
yuxianrz 819790f
Move MFA handler to auth2
yuxianrz a7eda04
Fix SSO migration from production auth
liramon1 7919e19
Move IAM profile options into typed object
liramon1 a90ae99
Remove STS cache watcher
liramon1 43f43b7
Fix SSO migration from production auth
liramon1 5369d57
fix authUtil tests and description for getMfaSerial
yuxianrz 6be4247
feat: add telemetry
yuxianrz db06902
revert package.json change
yuxianrz 6b7a928
Remove duplicate code
liramon1 cd42ede
Remove duplicate code
liramon1 ab1d1f1
Merge branch 'feature/telemetry' of github.com:liramon1/aws-toolkit-v…
yuxianrz e68c63c
change inline chat telemetry
yuxianrz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this to inlineChat instead of generic Chat ?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason I didn't change that is in aws-toolkit-common, cwprChatConversationType is defined as such:
{
"name": "cwsprChatConversationType",
"type": "string",
"allowedValues": [
"Chat",
"Assign",
"Transform",
"AgenticChat",
"AgenticChatWithToolUse"
],
"description": "Identifies the type of conversation"
},
Chat might be the most suitable value here. If I can make a PR to change this type in commonDefinition, I will add inlineChat and change the code here as well.