fix(amazonq): should emit UTDE telemetry before applying the Edits content #7864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For Edits, we emit UTDE telemetry after applying the Edits contents.
After we apply the Edits content, auto trigger may be performed. During the auto trigger, the session is closed and new session is created.
As a result, the session may be closed before we emit UTDE telemetry, resulting in no UTDE telemetry being emitted: https://github.com/aws/language-servers/blob/main/server/aws-lsp-codewhisperer/src/language-server/inline-completion/codeWhispererServer.ts#L616
For inline completion, we emit UTDE metrics before applying the new content: https://github.com/aws/aws-toolkit-vscode/blob/master/packages/amazonq/src/app/inline/completion.ts#L143-L159
Solution
Emit UTDE telemetry before applying the Edits content
feature/xbranches will not be squash-merged at release time.