Skip to content

Conversation

@floralph
Copy link
Contributor

Problem

Amazon Q edit suggestions remain active even when users navigate far away from the suggestion location, leading to confusion and potential unintended edits when users accept suggestions they can no longer see.

Solution

Added automatic rejection of edit suggestions when the cursor moves more than 25 lines away from the suggestion location. Implemented cursor change listener with proper cleanup to prevent memory leaks and ensure suggestions are only accepted when contextually relevant.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@floralph floralph requested a review from a team as a code owner August 12, 2025 01:18
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@floralph floralph force-pushed the floralph/cursor-edit-reject branch 4 times, most recently from fb21f0b to 9073ad5 Compare August 12, 2025 02:06
@floralph floralph force-pushed the floralph/cursor-edit-reject branch from 9073ad5 to 91265fe Compare August 12, 2025 02:38
@floralph
Copy link
Contributor Author

/retry

@floralph floralph closed this Aug 12, 2025
@floralph floralph deleted the floralph/cursor-edit-reject branch August 12, 2025 02:42
@floralph floralph restored the floralph/cursor-edit-reject branch August 12, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant