Skip to content

config: update rc branch naming and sanitize input #7869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

config: update rc branch naming and sanitize input #7869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
run: |
RC_NAME=$(echo ${{ github.ref_name }} | sed 's/release\///')
echo "FEAT_NAME=" >> $GITHUB_ENV
echo "TAG_NAME=rc-$RC_NAME" >> $GITHUB_ENV
echo "TAG_NAME=$RC_NAME" >> $GITHUB_ENV
- if: github.ref_name == 'master'
run: |
echo "FEAT_NAME=" >> $GITHUB_ENV
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/setup-release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@ jobs:

- name: Calculate Release Versions
id: release-version
env:
CUSTOM_VERSION: ${{ inputs.customVersion }}
VERSION_INCREMENT: ${{ inputs.versionIncrement }}
run: |
customVersion="${{ inputs.customVersion }}"
versionIncrement="${{ inputs.versionIncrement }}"
customVersion="$CUSTOM_VERSION"
versionIncrement="$VERSION_INCREMENT"

increment_version() {
local currentVersion=$1
Expand Down Expand Up @@ -84,7 +87,7 @@ jobs:
# Use date-based branch naming instead of version-based because we release
# both extensions (toolkit and amazonq) from the same branch, and they may
# have different version numbers. We can change this in the future
echo "BRANCH_NAME=rc-$(date +%Y%m%d)" >> $GITHUB_OUTPUT
echo "BRANCH_NAME=release/rc-$(date +%Y%m%d)" >> $GITHUB_OUTPUT

- name: Create RC Branch and Update Versions
env:
Expand Down
Loading