Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Aug 12, 2025

Problem

The inline completion in Jupyter Notebook is not working. https://github.com/aws/aws-toolkit-vscode/pull/7086/files is gone after inline completion migration to language server.

Solution

  1. Re-implement inline completion in Notebook
  2. Re-organize the left and right context given precise cursor position in current cell.

Requires aws/language-servers#2114

Screenshot 2025-08-12 at 4 09 28 PM
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner August 12, 2025 23:13
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@leigaol leigaol marked this pull request as draft August 12, 2025 23:13
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@leigaol leigaol marked this pull request as ready for review August 13, 2025 00:02
@leigaol leigaol merged commit 9859944 into aws:master Aug 13, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants