feat(amazonq): Improve the button clicking logic, replaced the MCP test suite #7881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| buttonWrapperSelector: string, | ||
| buttonContentSelector: string, | ||
| buttonName: string = 'button', | ||
| timeout: number = 5000 |
There was a problem hiding this comment.
Just wondering but is this timeout just arbitrary or needed for waiting for the css?
| .getDriver() | ||
| .wait(until.elementLocated(By.css(buttonContentSelector)), timeout, `${buttonName} content not found`) | ||
|
|
||
| const button = await buttonContent.findElement(By.xpath('./..')) |
There was a problem hiding this comment.
What does this xpath do? A little curious since it seems new
surajrdy-aws
approved these changes
Aug 14, 2025
surajrdy-aws
left a comment
surajrdy-aws
left a comment
There was a problem hiding this comment.
LGTM! I see try catches within the clickButton but I think it will still error out correctly right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I researched how we can make a very robust button clicking logic using Selenium best practices. I added this new general function into generalUtils.ts and replaced the MCP test suite with this logic so it no longer flakes.
feature/xbranches will not be squash-merged at release time.