fix(amazonq): Reducing error propagation flakiness in UI E2E Tests in utils and Helpers #7882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
laura-codess
approved these changes
Aug 13, 2025
laura-codess
left a comment
laura-codess
left a comment
There was a problem hiding this comment.
LGTM, looks like the only logic changed is just removing the try catch blocks
Hweinstock
reviewed
Aug 15, 2025
| } | ||
| for (const button of closeButtons) { | ||
| await button.click() | ||
| await sleep(500) |
Contributor
There was a problem hiding this comment.
todo: look into this sleep.
Hweinstock
approved these changes
Aug 15, 2025
Contributor
Hweinstock
left a comment
Hweinstock
left a comment
There was a problem hiding this comment.
thanks for making this change! I think the error flow will be much more straightforward.
| * @throws Error if timeout occurs before response is detected | ||
| */ | ||
| export async function waitForChatResponse(webview: WebviewView, timeout = 8000): Promise<boolean> { | ||
| export async function waitForChatResponse(webview: WebviewView, timeout = 15000): Promise<void> { |
Contributor
There was a problem hiding this comment.
out of curiosity, is there a reason we need to increase the default here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our tests are currently experiencing flakiness due to our usage of try-catch blocks which allow errors to pass through our tests. One of our more egregious examples of this is our
quickActions.test.tsfile which is unable to find the proper CSS element of our quickAction command overlay, but still allows our test to pass as this error is non-critical due to our try-catch block. This leaves an inherent problem in our tests making them flaky while still containing UI errors. Additionally, many of our helper functions return Booleans, and this logic of booleans is used in some instances like ourchat.test.ts.Solution
We will remove the majority of try-catch blocks that are used in our helpers to have more stricter errors in our tests. Our tests should fail if an error occurs while finding a UI element. Additionally, we update our
chat.test.tsso that it can properly stop using the Boolean returned from the chat helper function.We have updated:
feature/xbranches will not be squash-merged at release time.