feat(amazonq): Enable users to edit code files directly on the diff view #7886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Contributor
|
What happens when user clicks the diff view again after editing and closing it? |
jguoamz
reviewed
Aug 14, 2025
| const originalContent = params.originalFileContent ?? '' | ||
|
|
||
| // Clean up any existing temp files first | ||
| for (const tempFile of tempDiffFiles) { |
Contributor
There was a problem hiding this comment.
we tried using a temp file before, but this causes issues like the temp file now showing up in recent files in the IDE
Contributor
Author
There was a problem hiding this comment.
This file is only created at OS/tmp and cleaned up immediately after the diff view is closed. It will not show up at the VSC's workspace file list or work tree!
MarcoWang3
force-pushed
the
feature/editable_diffview
branch
from
5dfa590 to
c722999
Compare
jguoamz
approved these changes
Aug 14, 2025
ctlai95
approved these changes
Aug 14, 2025
tsmithsz
approved these changes
Aug 14, 2025
ashishrp-aws
approved these changes
Aug 14, 2025
MarcoWang3
changed the base branch from
feature/auto-debug
to
feature/editable_diffview
Normicrypto
approved these changes
Sep 10, 2025
bywang56
pushed a commit
that referenced
this pull request
Sep 11, 2025
…iew (#8019) ## Problem Currently users couldn't edit code files on the diff view provided by Amazon Q. Users have to open those files in the workspace to edit them. This is very inconvenient. ## Solution Copy of #7886 Enable users to edit code files directly on the diff view. https://github.com/user-attachments/assets/464d9757-cb6f-4f0f-aa6f-de4f3104cdb5 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently users couldn't edit code files on the diff view provided by Amazon Q. Users have to open those files in the workspace to edit them. This is very inconvenient.
Solution
Enable users to edit code files directly on the diff view.
Screen.Recording.2025-08-13.at.2.16.11.PM.mov
feature/xbranches will not be squash-merged at release time.