Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Aug 14, 2025

Problem

Language server is using initializeParams.initializationOptions?.aws?.clientInfo?.version
https://github.com/aws/language-servers/blob/main/server/aws-lsp-codewhisperer/src/shared/telemetryUtils.ts#L99-L100

However current we're passing IDE version (vscode) and use the other field as plugin version which is not used by server.

clientInfo: {
                    name: getClientName(),
                    version: version,
                    extension: {
                        name: 'AmazonQ-For-VSCode',
                        version: extensionVersion,

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner August 14, 2025 10:07
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Will-ShaoHua Will-ShaoHua changed the title fix: vscode is passing IDE version instead of extension version to la… fix(amazonq): vscode is passing IDE version instead of extension version to la… Aug 14, 2025
@Will-ShaoHua Will-ShaoHua changed the title fix(amazonq): vscode is passing IDE version instead of extension version to la… fix(amazonq): vscode is passing IDE version instead of extension version to lsp Aug 14, 2025
@Will-ShaoHua Will-ShaoHua changed the title fix(amazonq): vscode is passing IDE version instead of extension version to lsp fix(amazonq): should send extension version instead of IDE version in telemetry Aug 14, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Aug 14, 2025

verified

{ideCategory: 'VSCODE', operatingSystem: 'MAC', product: 'INLINE', clientId: 'FOOOOOOOOOOOOOOOO, ideVersion: 'testPluginVersion'}

@leigaol leigaol merged commit 8be30f1 into aws:master Aug 14, 2025
31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the ide-version branch August 14, 2025 21:28
Will-ShaoHua added a commit to Will-ShaoHua/aws-toolkit-vscode that referenced this pull request Aug 19, 2025
leigaol pushed a commit that referenced this pull request Aug 19, 2025
…ersion in telemetry (#7929)

…"

This reverts commit 8be30f1.

## Problem


## Solution

should use this instead
aws/language-servers#2142


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants