-
Notifications
You must be signed in to change notification settings - Fork 731
fix(amazonq): should send extension version instead of IDE version in telemetry #7893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
|
verified |
…ersion in telemetry (#7929) …" This reverts commit 8be30f1. ## Problem ## Solution should use this instead aws/language-servers#2142 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem
Language server is using
initializeParams.initializationOptions?.aws?.clientInfo?.versionhttps://github.com/aws/language-servers/blob/main/server/aws-lsp-codewhisperer/src/shared/telemetryUtils.ts#L99-L100
However current we're passing IDE version (vscode) and use the other field as plugin version which is not used by server.
Solution
feature/xbranches will not be squash-merged at release time.