-
Notifications
You must be signed in to change notification settings - Fork 730
fix(amazonq): Fix Quick Actions Test Suite #7930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| */ | ||
| import '../utils/setup' | ||
| import { WebviewView } from 'vscode-extension-tester' | ||
| import { closeAllTabs, dismissOverlayIfPresent } from '../utils/cleanupUtils' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think we should fix the dismissOverlayIfPresent or is it not needed anymore?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch, I think we should probably just delete the code for it until we find a better way to implement it, I'll make that change |
||
| import { closeAllTabs } from '../utils/cleanupUtils' | ||
| import { testContext } from '../utils/testContext' | ||
| import { clickQuickActionsCommand } from '../helpers/quickActionsHelper' | ||
| import { clearChatInput } from '../utils/generalUtils' | ||
|
|
@@ -18,17 +18,19 @@ describe('Amazon Q Chat Quick Actions Functionality', function () { | |
| webviewView = testContext.webviewView | ||
| }) | ||
|
|
||
| after(async function () { | ||
| afterEach(async () => { | ||
| await closeAllTabs(webviewView) | ||
| }) | ||
|
|
||
| afterEach(async () => { | ||
| // before closing the tabs, make sure that any overlays have been dismissed | ||
| await dismissOverlayIfPresent(webviewView) | ||
| it('/help Test', async () => { | ||
| await clickQuickActionsCommand(webviewView, '/help') | ||
| await clearChatInput(webviewView) | ||
| }) | ||
|
|
||
| it('Quick Actions Test', async () => { | ||
| await clickQuickActionsCommand(webviewView, 'dev') | ||
| it('/clear Test', async () => { | ||
| await clickQuickActionsCommand(webviewView, '/clear') | ||
| }) | ||
| it('/compact Test', async () => { | ||
| await clickQuickActionsCommand(webviewView, '/compact') | ||
| await clearChatInput(webviewView) | ||
| }) | ||
| }) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be worth adding a comment of why this is needed.