Skip to content

Conversation

@chungjac
Copy link
Contributor

Problem

Keyboard shortcuts for fixCode and generateUnitTests functions are not working on Windows VSC, although they function correctly on Mac

The current shortcuts conflict with Windows reserved keyboard combinations.

Current Shortcuts (Windows):

  • fixCode: Windows + Alt + Y
  • generateUnitTests: Windows + Alt + T

New Shortcuts (Windows only):

  • fixCode: Windows + Alt + H
  • generateUnitTests: Windows + Alt + N

Solution

This approach results in different letter keys for the same functions across platforms:

  • generateUnitTests: 'T' on Mac, 'N' on Windows
  • fixCode: 'Y' on Mac, 'H' on Windows

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner August 27, 2025 19:35
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@chungjac chungjac changed the title fix: windows keyboard shortcut for fixCode and generateUnitTests fix(amazonq): windows keyboard shortcut for fixCode and generateUnitTests Aug 27, 2025
@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@chungjac chungjac closed this Aug 27, 2025
@chungjac chungjac reopened this Aug 27, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@chungjac
Copy link
Contributor Author

/retryBuilds

@chungjac chungjac merged commit 27753b3 into aws:master Aug 27, 2025
64 of 68 checks passed
@chungjac chungjac deleted the keybaord branch October 8, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants