feat(sagemakerunifiedstudio): Support for SageMaker Unified Studio #7991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem - DeepLink remote connections should be able to reconnect automatically when the connection drops. ## Solution - Reintroduced and updated logic to handle DeepLink reconnection by redirecting the user to the Studio UI to refetch the session token. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem
When persisting selected domains/users that the customer manually
filtered, we did not take into account the region that the customer was
operating in. Thus, the filtering mechanism was incorrectly being
applied to all regions.
Example:
```
[
[
'arn:aws:iam:user/user1',
['domain1__pdx-1', 'domain1__pdx-2']
],
]
```
## Solution
When persisting the selected domains/users in global state, we insert
another level to track region. Example:
```
[
[
'us-west-2',
[
[
'arn:aws:iam:user/user1',
['domain1__pdx-1', 'domain1__pdx-2']
]
]
],
[
'us-east-1',
[
[
'arn:aws:iam:user/user1',
['domain1__iad-1', 'domain1__iad-2']
]
]
]
]
```
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
---------
Co-authored-by: Newton Der <[email protected]>
laileni-aws
reviewed
Sep 5, 2025
| } | ||
| } | ||
|
|
||
| if (value === Constants.LOCAL_PYTHON || value === undefined) { |
Contributor
There was a problem hiding this comment.
nit: Scope for refactoring not a blocker though
const shouldResetProject = value !== previousConnection || !state.project
if (shouldResetProject) {
state.project = undefined
if (value === Constants.LOCAL_PYTHON || (value && value !== previousConnection)) {
this.setDefaultProjectForConnection(cell, value)
}
}
laileni-aws
reviewed
Sep 5, 2025
| if (hasLocalMagic) { | ||
| const magicCommand = this.getMagicCommand(cell) | ||
| if (magicCommand) { | ||
| if (isMagicCommand) { |
laileni-aws
reviewed
Sep 5, 2025
| : [createPlaceholderItem(NO_DATA_FOUND_MESSAGE) as RedshiftNode] | ||
| } catch (err) { | ||
| logger.error(`Failed to get columns: ${(err as Error).message}`) | ||
| const errorMessage = (err as Error).message |
Contributor
There was a problem hiding this comment.
nit: This variable can be declared at L699 instead
laileni-aws
reviewed
Sep 5, 2025
| smusConnectionType: connection.type, | ||
| smusProjectRegion: connection.location?.awsRegion, | ||
| }) | ||
| try { |
Contributor
There was a problem hiding this comment.
There is code duplication in this try catch block
- Extract helper functions.
laileni-aws
reviewed
Sep 5, 2025
| return false | ||
| } | ||
|
|
||
| export function getFormattedDateTime(utcString: string): string { |
Contributor
There was a problem hiding this comment.
This function can be moved to shared/utils
laileni-aws
reviewed
Sep 5, 2025
| return formatted | ||
| } | ||
|
|
||
| export function getFormattedCurrentTime(): string { |
laileni-aws
reviewed
Sep 5, 2025
| @@ -0,0 +1 @@ | |||
| # Common business logic and APIs for SageMaker Unified Studio features | |||
laileni-aws
reviewed
Sep 5, 2025
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| export const errorCode = { |
Contributor
There was a problem hiding this comment.
We can move this to shared/errors may be
laileni-aws
approved these changes
Sep 5, 2025
Contributor
laileni-aws
left a comment
laileni-aws
left a comment
There was a problem hiding this comment.
Please address comments in followup PR's
Thanks
bharathGuntamadugu
force-pushed
the
master
branch
from
7872634 to
0a8b981
Compare
* SMUS needs to be activated in NodeJS environment only. * Remove Notebook resources * Added changelog
bharathGuntamadugu
force-pushed
the
master
branch
from
0a8b981 to
10e40ee
Compare
Will-ShaoHua
approved these changes
Sep 8, 2025
spkamboj
approved these changes
Sep 8, 2025
Contributor
|
/retryBuilds |
Will-ShaoHua
changed the title
Contributor
|
/retryBuilds |
1 similar comment
Contributor
|
/retryBuilds |
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
🔴 I'm not able to complete the code review because the diff size exceeds the limits. Consider splitting your changes into smaller diffs and try again. For more information, see Diff limits in the GitHub documentation Request ID : 1d0618bd-8f3a-487a-8f73-c4d99dfa555d |
Contributor
|
/retryBuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Access SMUS from IDE.
Solution
Support IDE support for Unified Studio
feature/xbranches will not be squash-merged at release time.