Skip to content

Conversation

@vpbhargav
Copy link
Contributor

Description

We were seeing intermittent issues where sometimes the context was being returned as undefined.

Setting it at the start of the activation to ensure the the context is available always.

Motivation

Bug fix

Testing Done

Tested manually locally.

Problem

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vpbhargav vpbhargav requested a review from a team as a code owner September 10, 2025 09:32
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

Copy link
Contributor

@bharathGuntamadugu bharathGuntamadugu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hours of effort for this change. :). Lets also make sure that this is going through for LocalIDE now.

@vpbhargav
Copy link
Contributor Author

/retryTests

@vpbhargav vpbhargav force-pushed the master branch 2 times, most recently from a37ba96 to f7312a9 Compare September 10, 2025 10:45
@vpbhargav
Copy link
Contributor Author

Failing unit tests in build are unrelated to PR

" 1 failing

  1. AppBuilder Walkthrough
    Create project
    start with an existing template
    override existing template
    download serverlessland proj:
    Error: Test length exceeded max duration: 30 seconds
    [No Pending UI Elements Found]
    at Timeout._onTimeout (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/test/setupUtil.ts:46:32)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)
    "

and

" 1 failing

  1. Notifications Rendering
    executes updateAndReload type button:
    Error: Could not find the specified item "Update and Reload" on message: severity: Error, message: Webview error, items: View Logs..."

**Description**

We were seeing intermittent issues where sometimes the context was
being returned as undefined.

Setting it at the start of the activation to ensure the the context is
available always.

**Motivation**

Bug fix

**Testing Done**

Tested manually locally.
@tsmithsz tsmithsz merged commit a942068 into aws:master Sep 10, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants