-
Notifications
You must be signed in to change notification settings - Fork 730
fix(smus): Fix potential race condition bug on getting context #8011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
bharathGuntamadugu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hours of effort for this change. :). Lets also make sure that this is going through for LocalIDE now.
|
/retryTests |
a37ba96 to
f7312a9
Compare
|
Failing unit tests in build are unrelated to PR " 1 failing
and " 1 failing
|
**Description** We were seeing intermittent issues where sometimes the context was being returned as undefined. Setting it at the start of the activation to ensure the the context is available always. **Motivation** Bug fix **Testing Done** Tested manually locally.
Description
We were seeing intermittent issues where sometimes the context was being returned as undefined.
Setting it at the start of the activation to ensure the the context is available always.
Motivation
Bug fix
Testing Done
Tested manually locally.
Problem
Solution
feature/xbranches will not be squash-merged at release time.