refactor(lambda): migrate to aws-sdk v3 #8041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Contributor
Author
|
/retryBuild |
ashishrp-aws
approved these changes
Sep 16, 2025
Contributor
Author
|
/retryBuilds |
Contributor
Author
|
/retryBuilds |
laileni-aws
approved these changes
Sep 19, 2025
ctlai95
merged commit 665d5a8
into
aws:feature/v2-to-v3-migration
21 of 22 checks passed
valerena
reviewed
Oct 1, 2025
Contributor
valerena
left a comment
valerena
left a comment
There was a problem hiding this comment.
The vast majority of changes are just Type changes, so this would be a good place to look at if you ever want to start using import type for Types, because you could add that to all these Runtimes and others that are imported only for typing.
But overall it looks good, I just added a question on why we had to add as Runtime only some times. Thanks!
Comment on lines
+97
to
+98
| [RuntimeFamily.NodeJS, 'nodejs22.x' as Runtime], | ||
| [RuntimeFamily.Python, 'python3.13' as Runtime], |
Contributor
There was a problem hiding this comment.
Is there any reason why only some of these are marked with as Runtime?
chungjac
added a commit
that referenced
this pull request
Oct 21, 2025
## Note **There is still a little bit more work needed for fully migrating aws-sdk v2 to v3, specifically all of these clients [here](https://github.com/aws/aws-toolkit-vscode/blob/59fd17fcfa22798e78d0df196290edb4a070f7ec/packages/core/scripts/build/generateServiceClient.ts#L232-L251) from the `generateServiceClient.ts` script** ## Problem AWS SDK V2 is at EOL ## Solution Migrate AWS SDK V2 to V3 This work has been done in the `feature/v2-to-v3-migration` feature branch and thus merging it into `master` Here are the PRs, which this does not include the merges from main and resolving conflicts: - #8043 - #8042 - #8046 - #8054 - #8041 - #8056 - #8081 - #8069 - #8067 - #8093 - #8095 - #8094 - #8171 - #8159 - #8175 - #8182 ## Testing Manually tested the [prerelease builds](https://github.com/aws/aws-toolkit-vscode/releases/tag/pre-v2-to-v3-migration) https://github.com/user-attachments/assets/b1d4795c-4027-462e-a195-509ac4a9d8ae --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <[email protected]> Co-authored-by: Tai Lai <[email protected]> Co-authored-by: invictus <[email protected]> Co-authored-by: Laxman Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AWS SDK v2 is at EOL. All clients should migrate to V3
Solution
Migrate Lambda client to AWS SDK V3
feature/xbranches will not be squash-merged at release time.