Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

Problem

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Will-ShaoHua Will-ShaoHua changed the title Telemetry telemetry: should send suggestion type Sep 19, 2025
@Will-ShaoHua Will-ShaoHua reopened this Sep 19, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make any change on this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp paste from the runtimeServiceModel artifact

@Will-ShaoHua Will-ShaoHua changed the title telemetry: should send suggestion type telemetry: should send suggestionType/pluginVersion via sendTelemetryEvent api Sep 19, 2025
@Will-ShaoHua Will-ShaoHua merged commit 1f62501 into aws:master Sep 19, 2025
30 of 31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the telemetry branch September 19, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants