Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Sep 23, 2025

Problem

  1. timestamp used in LSP path is cross-process, which requires a common starting point, so should use epoch based time instead of peformance.now() which starts at process starting point.

Solution

  1. replace all performance.now with Date.now()

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner September 23, 2025 22:57
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Will-ShaoHua Will-ShaoHua changed the title fix: unified timestamp with epoch time fix(amazonq): unified timestamp with epoch time Sep 23, 2025
@Will-ShaoHua Will-ShaoHua reopened this Sep 23, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Will-ShaoHua
Copy link
Contributor Author

confirmed no performance.now() used in inline path

image image

@Will-ShaoHua Will-ShaoHua merged commit da8fc99 into aws:master Sep 26, 2025
29 of 31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the telemetry branch September 26, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants