Skip to content

fix(amazonq): remove flaky unit test #8116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix(amazonq): remove flaky unit test #8116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 28 additions & 30 deletions packages/amazonq/test/unit/codewhisperer/service/recommendationHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,8 @@ import {
session,
AuthUtil,
DefaultCodeWhispererClient,
RecommendationsList,
ConfigurationEntry,
RecommendationHandler,
CodeWhispererCodeCoverageTracker,
supplementalContextUtil,
} from 'aws-core-vscode/codewhisperer'
import {
Expand Down Expand Up @@ -54,35 +52,35 @@ describe('recommendationHandler', function () {
sinon.restore()
})

it('should assign correct recommendations given input', async function () {
assert.strictEqual(CodeWhispererCodeCoverageTracker.instances.size, 0)
assert.strictEqual(
CodeWhispererCodeCoverageTracker.getTracker(mockEditor.document.languageId)?.serviceInvocationCount,
0
)
// it('should assign correct recommendations given input', async function () {
// assert.strictEqual(CodeWhispererCodeCoverageTracker.instances.size, 0)
// assert.strictEqual(
// CodeWhispererCodeCoverageTracker.getTracker(mockEditor.document.languageId)?.serviceInvocationCount,
// 0
// )

const mockServerResult = {
recommendations: [{ content: "print('Hello World!')" }, { content: '' }],
$response: {
requestId: 'test_request',
httpResponse: {
headers: {
'x-amzn-sessionid': 'test_request',
},
},
},
}
const handler = new RecommendationHandler()
sinon.stub(handler, 'getServerResponse').resolves(mockServerResult)
await handler.getRecommendations(mockClient, mockEditor, 'AutoTrigger', config, 'Enter', false)
const actual = session.recommendations
const expected: RecommendationsList = [{ content: "print('Hello World!')" }, { content: '' }]
assert.deepStrictEqual(actual, expected)
assert.strictEqual(
CodeWhispererCodeCoverageTracker.getTracker(mockEditor.document.languageId)?.serviceInvocationCount,
1
)
})
// const mockServerResult = {
// recommendations: [{ content: "print('Hello World!')" }, { content: '' }],
// $response: {
// requestId: 'test_request',
// httpResponse: {
// headers: {
// 'x-amzn-sessionid': 'test_request',
// },
// },
// },
// }
// const handler = new RecommendationHandler()
// sinon.stub(handler, 'getServerResponse').resolves(mockServerResult)
// await handler.getRecommendations(mockClient, mockEditor, 'AutoTrigger', config, 'Enter', false)
// const actual = session.recommendations
// const expected: RecommendationsList = [{ content: "print('Hello World!')" }, { content: '' }]
// assert.deepStrictEqual(actual, expected)
// assert.strictEqual(
// CodeWhispererCodeCoverageTracker.getTracker(mockEditor.document.languageId)?.serviceInvocationCount,
// 1
// )
// })

it('should assign request id correctly', async function () {
const mockServerResult = {
Expand Down
Loading