Skip to content

test(amazonq): proxy #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

test(amazonq): proxy #8133

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1ec81c
test: proxy
Will-ShaoHua Oct 3, 2025
9193e69
123
Will-ShaoHua Oct 3, 2025
a5604b0
debug log
Will-ShaoHua Oct 3, 2025
38e6cba
a
Will-ShaoHua Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/core/src/shared/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
*/

import crossFetch from 'cross-fetch'
import { getLogger } from './logger'

Check failure on line 7 in packages/core/src/shared/request.ts

View workflow job for this annotation

GitHub Actions / lint (18.x, stable) 

do not import from folders or index.ts files since it can cause circular dependencies. import from the file directly
const { HttpsProxyAgent } = require('https-proxy-agent')

const request = {
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/shared/resourcefetcher/httpResourceFetcher.ts#L105-L129

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suspecting proxy is not applied to the language server download path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call stack

/**
Expand All @@ -23,7 +25,20 @@
params?: RequestParamsArg,
wrappedFetch = crossFetch
): FetchRequest {
return new FetchRequest(url, { ...params, method }, wrappedFetch)
const proxy = process.env.HTTPS_PROXY || process.env.HTTP_PROXY
if (proxy) {
getLogger().info(`detectied proxy being used via env variable and is attaching ${proxy} to userAgent`)
}
const updateParams: any = { ...params }
if (proxy) {
const proxyAgent = new HttpsProxyAgent(proxy)
updateParams.agent = proxyAgent
updateParams.headers = {
...(params?.headers || {}), // ???? do we need this?
}
}

return new FetchRequest(url, { ...updateParams, method }, wrappedFetch)
},
}
export default request
Expand Down
Loading