-
Notifications
You must be signed in to change notification settings - Fork 730
feat(stepfunctions): Auto fill existing ExecutionInput when click StartExecution from ExecutionDetails tab. #8135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…m ExecutionDetails tab.
|
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type": "Feature", | |||
| "description": "[Step Functions] Start Execution from Execution Details tab now fills the existing Execution Input in the Start Execution tab." | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a new changelog for this since it's not released yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we need to keep the changelog for every changes even it's unreleased. If not I can remove this entry.
| "description": "AWS Contributed Icon", | ||
| "default": { | ||
| "fontPath": "./resources/fonts/aws-toolkit-icons.woff", | ||
| "fontCharacter": "\\f1d0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes don't look related, can you remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this seems like a result of npm instsall. Let me see why this is here and remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: it seems like npm install will always bring back this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to sync changes in the feature branch since it's 600 commits behind. Can you update the feature branch and rebase this change on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can do a merge from master first.
| async created() { | ||
| this.initialData = (await client.init()) ?? this.initialData | ||
| if (this.initialData.executionInput) { | ||
| this.executionInput = this.initialData.executionInput |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we auto format it like the console?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add that. Let me see how I can achieve that.
…m ExecutionDetails tab.
Problem
When starting a new StateMachine execution from the ExecutionDetails tab, currently we do not fill the StartExecution tab with the existing ExecutionInput.
Solution
Auto fill existing ExecutionInput when click StartExecution from ExecutionDetails tab.
Demo
feature/xbranches will not be squash-merged at release time.