Skip to content

Conversation

@zelzhou
Copy link

@zelzhou zelzhou commented Oct 6, 2025

Problem

  1. We should auto fill the existing ExecutionInput when start a new execution in ExecutionDetails tab.
  2. Circular dependencies exists in the StepFunctions extension logic, we need to fix those circular dependency in order for the build to pass.

Solution

  1. Allow the CDN bundle to pass back the ExecutionInput when invoking startExecutionMessageHandler and added ExecutionInput parameter to executeStateMachine command.
  2. The circular dependencies were caused by a chain: ExecutionDetailProviderhandleMessageutilsexecuteStateMachineExecutionDetailProvider. Separating utils.ts into two files broke part of the cycle by removing webview functions from the utils that handleMessage needed. However, a direct cycle remained between executeStateMachine and ExecutionDetailProvider and we cannot break this cycle by separating the utils, we introduced a callback to openExecutionDetails in handleMessage -> executeStateMachine so that we don't need to static import ExecutionDetailProvider anymore.

Demo

StartExecutionFills


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zelzhou zelzhou requested a review from a team as a code owner October 6, 2025 23:59
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@zelzhou
Copy link
Author

zelzhou commented Oct 8, 2025

This PR is for an unreleased feature under development of the feature/stepfunction-execution branch

@zelzhou zelzhou force-pushed the feature/stepfunctions-execution branch from 20293a0 to 0940f11 Compare October 10, 2025 20:39
@laileni-aws
Copy link
Contributor

/retryBuilds

@laileni-aws laileni-aws enabled auto-merge (squash) October 16, 2025 16:54
@laileni-aws laileni-aws merged commit 84554e6 into aws:feature/stepfunctions-execution Oct 16, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants