-
Notifications
You must be signed in to change notification settings - Fork 746
feat(stepfunctions): Start Execution fills existing ExecutionInput #8147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laileni-aws
merged 6 commits into
aws:feature/stepfunctions-execution
from
zelzhou:feature/stepfunctions-execution
Oct 16, 2025
Merged
feat(stepfunctions): Start Execution fills existing ExecutionInput #8147
laileni-aws
merged 6 commits into
aws:feature/stepfunctions-execution
from
zelzhou:feature/stepfunctions-execution
Oct 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utionDetails tab.
|
Author
|
This PR is for an unreleased feature under development of the feature/stepfunction-execution branch |
anthonyting
reviewed
Oct 8, 2025
packages/core/src/stepFunctions/executionDetails/handleMessage.ts
Outdated
Show resolved
Hide resolved
anthonyting
reviewed
Oct 10, 2025
…callback to openExecutionDetails.
20293a0 to
0940f11
Compare
anthonyting
approved these changes
Oct 10, 2025
liliahache
approved these changes
Oct 10, 2025
laileni-aws
approved these changes
Oct 10, 2025
chungjac
approved these changes
Oct 15, 2025
Contributor
|
/retryBuilds |
84554e6
into
aws:feature/stepfunctions-execution
20 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
startExecutionMessageHandlerand added ExecutionInput parameter toexecuteStateMachinecommand.ExecutionDetailProvider→handleMessage→utils→executeStateMachine→ExecutionDetailProvider. Separatingutils.tsinto two files broke part of the cycle by removing webview functions from the utils thathandleMessageneeded. However, a direct cycle remained betweenexecuteStateMachineandExecutionDetailProviderand we cannot break this cycle by separating the utils, we introduced a callback to openExecutionDetails inhandleMessage->executeStateMachineso that we don't need to static importExecutionDetailProvideranymore.Demo
feature/xbranches will not be squash-merged at release time.