refactor(core): migrate various clients from aws-sdk v2 to v3 pt2 #8175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chungjac
force-pushed
the
migrate-service
branch
5 times, most recently
from
d92f77c to
24f0a05
Compare
chungjac
changed the title
manodnyab
reviewed
Oct 14, 2025
| private static readonly metadataServiceTimeout: number = 500 | ||
| // AWS EC2 Instance Metadata Service (IMDS) constants | ||
| // https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-metadata-v2-how-it-works.html | ||
| private static readonly metadataServiceHost: string = '169.254.169.254' |
There was a problem hiding this comment.
v2 had an abstraction layer and would use these values internally:
- https://github.com/aws/aws-sdk-js/blob/f5b1a6f0aebb477204d979091d654649f29ad9ce/lib/metadata_service/get_endpoint.js#L3
- https://github.com/aws/aws-sdk-js/blob/f5b1a6f0aebb477204d979091d654649f29ad9ce/lib/metadata_service.js#L130
v3 removed the abstraction layer, so v3 uses Smithy's httpRequest() which requires us to specify the host and path
169.254.169.254is the official AWS-defined IP for EC2 Instance Metadata Service (IMDS) as per: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html#instance-metadata-v2-how-it-works
chungjac
force-pushed
the
migrate-service
branch
from
24f0a05 to
165e3af
Compare
laileni-aws
approved these changes
Oct 14, 2025
ashishrp-aws
approved these changes
Oct 15, 2025
chungjac
added a commit
that referenced
this pull request
Oct 21, 2025
## Note **There is still a little bit more work needed for fully migrating aws-sdk v2 to v3, specifically all of these clients [here](https://github.com/aws/aws-toolkit-vscode/blob/59fd17fcfa22798e78d0df196290edb4a070f7ec/packages/core/scripts/build/generateServiceClient.ts#L232-L251) from the `generateServiceClient.ts` script** ## Problem AWS SDK V2 is at EOL ## Solution Migrate AWS SDK V2 to V3 This work has been done in the `feature/v2-to-v3-migration` feature branch and thus merging it into `master` Here are the PRs, which this does not include the merges from main and resolving conflicts: - #8043 - #8042 - #8046 - #8054 - #8041 - #8056 - #8081 - #8069 - #8067 - #8093 - #8095 - #8094 - #8171 - #8159 - #8175 - #8182 ## Testing Manually tested the [prerelease builds](https://github.com/aws/aws-toolkit-vscode/releases/tag/pre-v2-to-v3-migration) https://github.com/user-attachments/assets/b1d4795c-4027-462e-a195-509ac4a9d8ae --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-toolkit-automation <[email protected]> Co-authored-by: Tai Lai <[email protected]> Co-authored-by: invictus <[email protected]> Co-authored-by: Laxman Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AWS SDK V2 is at EOL. All client should migrate to V3.
Solution
More work has been done to migrate these clients:
feature/xbranches will not be squash-merged at release time.