-
Notifications
You must be signed in to change notification settings - Fork 728
fix(smus): fix refresh interval for tracking pending space nodes #8204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
| public readonly onDidChangeTreeItem = this.onDidChangeEmitter.event | ||
| public readonly onDidChangeChildren = this.onDidChangeEmitter.event | ||
| public readonly pollingSet: PollingSet<string> = new PollingSet(5, this.updatePendingNodes.bind(this)) | ||
| public readonly pollingSet: PollingSet<string> = new PollingSet(5000, this.updatePendingNodes.bind(this)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request, please check if we have other places where we have this issue as well. Also make the time value a constant with unit in name "...._POLLING_INTERVAL_SECS"
Fine to merge this now to mitigate impact and we can do it in some future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fixed.
|
Failing tests/builds are not related to change and seem to be flaky tests. |
Problem
Solution
feature/xbranches will not be squash-merged at release time.