Skip to content

fix(smus): fix refresh interval for tracking pending space nodes #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix(smus): fix refresh interval for tracking pending space nodes #8204

merged 1 commit into from
Oct 17, 2025

Conversation

@kzr-at-amazon
Copy link
Contributor

@kzr-at-amazon kzr-at-amazon commented Oct 17, 2025

Problem

  • On transitioning from "Stopped" to/from "Running", the space node calls trackPendingNode() which adds it to the PollingSet. The PollingSet starts polling every 5 milliseconds which calls describeSpace + describeApp

Solution

  • Update the polling interval to 5sec
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kzr-at-amazon kzr-at-amazon requested a review from a team as a code owner October 17, 2025 19:22
@amazon-inspector-ohio
Copy link

amazon-inspector-ohio bot commented Oct 17, 2025

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

amazon-inspector-ohio bot commented Oct 17, 2025

✅ I finished the code review, and didn't find any security or code quality issues.

vpbhargav
vpbhargav approved these changes Oct 17, 2025
View reviewed changes
...ges/core/src/sagemakerunifiedstudio/explorer/nodes/sageMakerUnifiedStudioSpacesParentNode.ts Outdated
public readonly onDidChangeTreeItem = this.onDidChangeEmitter.event
public readonly onDidChangeChildren = this.onDidChangeEmitter.event
public readonly pollingSet: PollingSet<string> = new PollingSet(5, this.updatePendingNodes.bind(this))
public readonly pollingSet: PollingSet<string> = new PollingSet(5000, this.updatePendingNodes.bind(this))
Copy link
Contributor

@vpbhargav vpbhargav Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, please check if we have other places where we have this issue as well. Also make the time value a constant with unit in name "...._POLLING_INTERVAL_SECS"

Fine to merge this now to mitigate impact and we can do it in some future PR.

Copy link
Contributor Author

@kzr-at-amazon kzr-at-amazon Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fixed.

@vpbhargav
Copy link
Contributor

vpbhargav commented Oct 17, 2025

Failing tests/builds are not related to change and seem to be flaky tests.

@chungjac chungjac merged commit 87228e3 into aws:master Oct 17, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shruti0085 shruti0085 shruti0085 approved these changes

@chungjac chungjac chungjac approved these changes

+3 more reviewers

@vpbhargav vpbhargav vpbhargav approved these changes

@dylanraws dylanraws dylanraws approved these changes

@PotatoWKY PotatoWKY PotatoWKY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kzr-at-amazon @vpbhargav @shruti0085 @dylanraws @chungjac @PotatoWKY