Skip to content

fix(sagemaker): Adjust retry configuration for StartSession #8219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

fix(sagemaker): Adjust retry configuration for StartSession #8219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbfb63
fix(sagemaker): Adjust retry configuration for StartSession
dylanraws Oct 21, 2025
e5863cc
Merge branch 'master' into start-session-retries
laileni-aws Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/core/src/awsService/sagemaker/detached-server/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import os from 'os'
import { join } from 'path'
import { SpaceMappings } from '../types'
import open from 'open'
import { ConfiguredRetryStrategy } from '@smithy/util-retry'
export { open }

export const mappingFilePath = join(os.homedir(), '.aws', '.sagemaker-space-profiles')
Expand All @@ -22,6 +23,13 @@ const tempFilePath = `${mappingFilePath}.tmp`
let isWriting = false
const writeQueue: Array<() => Promise<void>> = []

// Currently SSM registration happens asynchronously with App launch, which can lead to
// StartSession Internal Failure when connecting to a fresly-started Space.
// To mitigate, spread out retries over multiple seconds instead of sending all retries within a second.
// Backoff sequence: 1500ms, 2250ms, 3375ms
// Retry timing: 1500ms, 3750ms, 7125ms
const startSessionRetryStrategy = new ConfiguredRetryStrategy(3, (attempt: number) => 1000 * 1.5 ** attempt)

/**
* Reads the local endpoint info file (default or via env) and returns pid & port.
* @throws Error if the file is missing, invalid JSON, or missing fields
Expand Down Expand Up @@ -83,7 +91,7 @@ export function parseArn(arn: string): { region: string; accountId: string; spac

export async function startSagemakerSession({ region, connectionIdentifier, credentials }: any) {
const endpoint = process.env.SAGEMAKER_ENDPOINT || `https://sagemaker.${region}.amazonaws.com`
const client = new SageMakerClient({ region, credentials, endpoint })
const client = new SageMakerClient({ region, credentials, endpoint, retryStrategy: startSessionRetryStrategy })
const command = new StartSessionCommand({ ResourceIdentifier: connectionIdentifier })
return client.send(command)
}
Expand Down
Loading