fix(amazonq): include reason for inline notification #8273
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
| }, | ||
| "aws-schemas-schema": { | ||
| "description": "AWS Contributed Icon", | ||
| "default": { | ||
| "fontPath": "./resources/fonts/aws-toolkit-icons.woff", | ||
| "fontCharacter": "\\f1e9" | ||
| } | ||
| }, | ||
| "aws-stepfunctions-preview": { | ||
| "description": "AWS Contributed Icon", | ||
| "default": { | ||
| "fontPath": "./resources/fonts/aws-toolkit-icons.woff", | ||
| "fontCharacter": "\\f1ea" |
There was a problem hiding this comment.
should revert package.json i think
There was a problem hiding this comment.
i mean this packages/amazonq/package.json
There was a problem hiding this comment.
both jsons are modified from npm install so I assume we should commit both?
|
lgtm, but i assume we should merge lsp PR to bump runtime first ow passing this extra value will break? |
|
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
3 participants
Problem
We need a new parameter to differentiate implicit and explicit reject for inline
Solution
Include reason for inline notification
feature/xbranches will not be squash-merged at release time.