Skip to content

fix(sagemaker): Use SpaceSettingsSummary.AppType instead of App.AppType #8276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

fix(sagemaker): Use SpaceSettingsSummary.AppType instead of App.AppType #8276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04a70fa
fix(sagemaker): Use SpaceSettingsSummary.AppType instead of App.AppType
bhavya2109sharma Nov 10, 2025
2d6e92c
Merge branch 'master' into fix/sagemaker-commands-apptype
bhavya2109sharma Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/core/src/awsService/sagemaker/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export async function stopSpace(
await client.deleteApp({
DomainId: node.spaceApp.DomainId!,
SpaceName: spaceName,
AppType: node.spaceApp.App!.AppType!,
AppType: node.spaceApp.SpaceSettingsSummary!.AppType!,
AppName: node.spaceApp.App?.AppName,
})
} catch (err) {
Expand Down Expand Up @@ -319,7 +319,7 @@ async function handleRunningSpaceWithDisabledAccess(
await client.deleteApp({
DomainId: node.spaceApp.DomainId!,
SpaceName: spaceName,
AppType: node.spaceApp.App!.AppType!,
AppType: node.spaceApp.SpaceSettingsSummary!.AppType!,
AppName: node.spaceApp.App?.AppName,
})

Expand All @@ -329,7 +329,11 @@ async function handleRunningSpaceWithDisabledAccess(
// Start the space with remote access enabled (skip prompts since user already consented)
await client.startSpace(spaceName, node.spaceApp.DomainId!, true)
await tryRefreshNode(node)
await client.waitForAppInService(node.spaceApp.DomainId!, spaceName, node.spaceApp.App!.AppType!)
await client.waitForAppInService(
node.spaceApp.DomainId!,
spaceName,
node.spaceApp.SpaceSettingsSummary!.AppType!
)
await tryRemoteConnection(node, ctx, progress)
} catch (err: any) {
// Handle user declining instance type upgrade
Expand Down Expand Up @@ -369,7 +373,11 @@ async function handleStoppedSpace(
},
async (progress) => {
progress.report({ message: 'Starting the space' })
await client.waitForAppInService(node.spaceApp.DomainId!, spaceName, node.spaceApp.App!.AppType!)
await client.waitForAppInService(
node.spaceApp.DomainId!,
spaceName,
node.spaceApp.SpaceSettingsSummary!.AppType!
)
await tryRemoteConnection(node, ctx, progress)
}
)
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/test/awsService/sagemaker/commands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ describe('SageMaker Commands', () => {
AppName: 'default',
},
SpaceSettingsSummary: {
AppType: 'JupyterLab',
RemoteAccess: 'DISABLED',
},
},
Expand Down
Loading