Skip to content

Conversation

@bhavya2109sharma
Copy link
Contributor

Problem

  • Users could click start/stop buttons on SageMaker spaces while they were already in the process of starting or stopping.

Solution

  • Disables start/stop buttons when SageMaker space is in STARTING or STOPPING state to prevent invalid operations during state transitions.
  • Added pending state check in getContext() method
  • Returns specific context values for pending states (smusSpacePendingNode/awsSagemakerSpacePendingNode) in package.json [openRemoteConnection]

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhavya2109sharma bhavya2109sharma requested a review from a team as a code owner November 11, 2025 19:58
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

"command": "aws.sagemaker.openRemoteConnection",
"group": "inline@1",
"when": "view != aws.smus.rootView && viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/"
"when": "view != aws.smus.rootView && viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/ && viewItem != awsSagemakerSpacePendingNode"
Copy link
Contributor

@PotatoWKY PotatoWKY Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from above sagemakerSpace.getContext() it seems that a Sagemaker space must be one of those 3,

  • awsSagemakerSpaceRunningNode
  • awsSagemakerSpacePendingNode
  • awsSagemakerSpaceNode

which means
viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/ && viewItem != awsSagemakerSpacePendingNode"
is equivalent to just
viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/

Maybe we can make this simpler?

@laileni-aws
Copy link
Contributor

If its user facing change! you can add a fix changeLog

@laileni-aws laileni-aws enabled auto-merge (squash) November 11, 2025 23:33
@bhavya2109sharma
Copy link
Contributor Author

If its user facing change! you can add a fix changeLog

This is introduced in last PR which is not yet released

@laileni-aws laileni-aws merged commit e1abbe6 into aws:master Nov 12, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants