-
Notifications
You must be signed in to change notification settings - Fork 731
fix(sagemaker): Disable start/stop button for intermediate state of the space #8282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
packages/toolkit/package.json
Outdated
| "command": "aws.sagemaker.openRemoteConnection", | ||
| "group": "inline@1", | ||
| "when": "view != aws.smus.rootView && viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/" | ||
| "when": "view != aws.smus.rootView && viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/ && viewItem != awsSagemakerSpacePendingNode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from above sagemakerSpace.getContext() it seems that a Sagemaker space must be one of those 3,
- awsSagemakerSpaceRunningNode
- awsSagemakerSpacePendingNode
- awsSagemakerSpaceNode
which means
viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/ && viewItem != awsSagemakerSpacePendingNode"
is equivalent to just
viewItem =~ /^(awsSagemakerSpaceRunningNode|awsSagemakerSpaceNode)$/
Maybe we can make this simpler?
5880a95 to
c9bd715
Compare
|
If its user facing change! you can add a fix changeLog |
This is introduced in last PR which is not yet released |
Problem
Solution
feature/xbranches will not be squash-merged at release time.