feat(lambda): add Lambda remote invoke multi-tenancy support #8541
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
licjun
changed the title
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
licjun
force-pushed
the
feat/mtm-remote-invoke
branch
from
0ffbdb7 to
38379fc
Compare
| runtimeSupportsRemoteDebug?: boolean | ||
| remoteDebugLayer?: string | undefined | ||
| isLambdaRemote?: boolean | ||
| hasTenancyConfig?: boolean |
There was a problem hiding this comment.
LambdaFunctionNode should have functionConfig which covers this info already
|
|
||
| if (remoteDebugEnabled) { | ||
| funcResponse = await this.clientDebug.invoke(this.data.FunctionArn, input, qualifier) | ||
| funcResponse = await this.clientDebug.invoke(this.data.FunctionArn, input, qualifier, tenantId) |
There was a problem hiding this comment.
help to add tail log param here to avoid potential issue in the future.
| funcResponse = await this.clientDebug.invoke(this.data.FunctionArn, input, qualifier, tenantId) | |
| funcResponse = await this.clientDebug.invoke(this.data.FunctionArn, input, qualifier, tenantId, 'Tail') |
There was a problem hiding this comment.
as there are more and more field in this invoke, potentially we can refactor it into
await this.clientDebug.invoke(params)
| const sdkClient = await this.createSdkClient() | ||
|
|
||
| const response = await sdkClient.send( | ||
| new InvokeCommand({ |
There was a problem hiding this comment.
should we throw error when user invoke multitenant func with undefined tenantId?
|
KHÔNG BUILD. Mục tiêu duy nhất: RÀ SOÁT – BÁO CÁO HIỆN TRẠNG PROJECT. Hãy trả lời CHỈ DƯỚI DẠNG BÁO CÁO KỸ THUẬT, theo đúng cấu trúc dưới đây. ==============================
|
3 participants
Problem
This is to support the Lambda multi-tenancy feature in toolkit.
Solution
Add conditional Tenant ID field to Remote Invoke panel for multi-tenant Lambda functions. The field appears when function has TenancyConfig and passes the value to AWS Lambda Invoke API.
feature/xbranches will not be squash-merged at release time.