Add comprehensive security scanning workflows#258
Add comprehensive security scanning workflows#258lukeina2z wants to merge 1 commit intoaws:masterfrom
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
lukeina2z
force-pushed
the
security-scan-pr
branch
2 times, most recently
from
4528070 to
2c2c959
Compare
lukeina2z
changed the title
lukeina2z
force-pushed
the
security-scan-pr
branch
from
d37bcd6 to
2233764
Compare
lukeina2z
changed the title
lukeina2z
force-pushed
the
security-scan-pr
branch
from
63ffb11 to
2233764
Compare
|
Tested these two added workflow in my fork repo. They are working as expected. CodeQL Security Analysis Daily Security Scan: |
…ning - Add comprehensive CodeQL security analysis workflow with: * Multi-layered Go vulnerability scanning (govulncheck, gosec, Nancy) * Trivy filesystem and dependency scanning * Detailed Go module dependency reporting * Enhanced SARIF integration for GitHub Security tab - Add comprehensive daily security scan workflow with: * Go module dependency scanning with multiple tools * Published Docker image vulnerability scanning (ECR and Docker Hub) * Build artifacts security scanning * Detailed reporting with vulnerability counts and actionable insights - Use Go 1.24.1 to match toolchain requirements and resolve compatibility issues - Enhanced error handling with continue-on-error for non-critical failures - Organized artifact collection for different scan types - Weekly CodeQL analysis and twice-daily comprehensive security scans
lukeina2z
force-pushed
the
security-scan-pr
branch
from
2233764 to
a8815ae
Compare
| go.list | ||
| go-mod-graph.txt | ||
| go-mod-why.txt | ||
| go-mod-versions.txt | ||
| trivy-go-results.sarif |
There was a problem hiding this comment.
How will we be using these report files? Is it for PR authors to look at?
| - name: Run govulncheck | ||
| run: | | ||
| go install golang.org/x/vuln/cmd/govulncheck@d1f380186385b4f64e00313f31743df8e4b89a77 # v1.1.4 | ||
| govulncheck ./... |
There was a problem hiding this comment.
Does this fail the workflow if there are vulnerabilities?
| GOFLAGS: -mod=mod | ||
| run: | | ||
| # Ensure go.sum is up to date | ||
| go mod tidy |
There was a problem hiding this comment.
Do we want to run daily scan on an up-to-date go.sum or the actual current go.sum?
| govulncheck-results.json | ||
| gosec-daily-results.json | ||
| trivy-daily-results.sarif | ||
| go-mod-download.json | ||
| go-mod-list.json | ||
| go.list |
There was a problem hiding this comment.
In your test run: https://github.com/lukeina2z/aws-xray-daemon/actions/runs/18145743999
I downloaded the artifacts, but only see trivy-daily-results.sarif. All others were missing.
2 participants
This commit implements complete security scanning for aws-xray-daemon:
CodeQL Security Analysis (.github/workflows/codeql-analysis.yml)
Daily Security Scan (.github/workflows/daily-scan.yml)
Key Features
Addresses the critical security gap where aws-xray-daemon had no automated security scanning despite being critical infrastructure used in production.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.