Skip to content

Add http field in Segment and Subsegment type #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add http field in Segment and Subsegment type #591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d240578
Add http field in Segment and Subsegment type
hermanho Jun 15, 2023
295f890
add RemoteRequestData
hermanho Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/core/lib/segments/attributes/subsegment.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as http from 'http';
import { Segment, SegmentLike } from '../../aws-xray';
import IncomingRequestData from '../../middleware/incoming_request_data';

declare class Subsegment {
id: string;
Expand All @@ -12,6 +13,8 @@ declare class Subsegment {
namespace?: string;
notTraced: boolean;

http?: IncomingRequestData;

constructor(name: string);

addNewSubsegment(name: string): Subsegment;
Expand Down
1 change: 1 addition & 0 deletions packages/core/lib/segments/segment.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ declare class Segment {
notTraced?: boolean;

additionalTraceData?: object
http?: IncomingRequestData;

constructor(name: string, rootId?: string | null, parentId?: string | null);

Expand Down