-
Notifications
You must be signed in to change notification settings - Fork 316
Add certificate renew command doc #9979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 4ba043f.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9979 +/- ##
=======================================
Coverage 69.98% 69.98%
=======================================
Files 680 680
Lines 51148 51148
=======================================
Hits 35798 35798
Misses 13551 13551
Partials 1799 1799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple of small suggestions.
## Overview | ||
|
||
EKS Anywhere provides a simple and recommended way to renew cluster certificates using the `eksctl anywhere renew certificates` command. This is the recommended approach for certificate renewal. | ||
Get more information on EKS Anywhere cluster certificates from [here]({{< relref "monitoring-certificates.md" >}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get more information on EKS Anywhere cluster certificates from [here]({{< relref "monitoring-certificates.md" >}}) | |
Get more information on EKS Anywhere cluster certificates from [Monitoring Certificate Expiration]({{< relref "monitoring-certificates.md" >}}) |
4. For control plane nodes: | ||
- Renewing all kubeadm certificates | ||
- Restarting static pods | ||
- Update external etcd key cert (if present) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update external etcd key cert (if present) | |
- Updating external etcd key cert (if present) |
{{% alert title="Note" color="primary" %}} | ||
While these manual steps renew the certificates, the [recommended method]({{< relref "eksctl-renew-certs.md" >}}) for certificate renewal is using the `eksctl anywhere renew certificates` command. | ||
{{% /alert %}} | ||
|
||
Certificates for external etcd and control plane nodes expire after 1 year in EKS Anywhere. This page shows the process for manually rotating certificates. | ||
|
||
Get more information on EKS Anywhere cluster certificates from [here]({{< relref "monitoring-certificates.md" >}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get more information on EKS Anywhere cluster certificates from [here]({{< relref "monitoring-certificates.md" >}}) | |
Get more information on EKS Anywhere cluster certificates from [Monitoring Certificate Expiration]({{< relref "monitoring-certificates.md" >}}) |
{{% alert title="Note" color="primary" %}} | ||
While this script-based approach is supported, the [recommended method]({{< relref "eksctl-renew-certs.md" >}}) for certificate renewal is using the `eksctl anywhere renew certificates` command. | ||
{{% /alert %}} | ||
|
||
Get more information on EKS Anywhere cluster certificates from [here]({{< relref "monitoring-certificates.md" >}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get more information on EKS Anywhere cluster certificates from [here]({{< relref "monitoring-certificates.md" >}}) | |
Get more information on EKS Anywhere cluster certificates from [Monitoring Certificate Expiration]({{< relref "monitoring-certificates.md" >}}) |
d029007
to
9646f17
Compare
/cherry-pick release-0.23 |
@panktishah26: once the present PR merges, I will cherry-pick it on top of release-0.23 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
||
## Overview | ||
|
||
EKS Anywhere provides a simple and recommended way to renew cluster certificates using the `eksctl anywhere renew certificates` command. This is the recommended approach for certificate renewal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the command reference to the eksctl commands reference page too
https://anywhere.eks.amazonaws.com/docs/reference/eksctl/
9646f17
to
c187116
Compare
@panktishah26: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
0486f51
to
9646f17
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@panktishah26: new pull request created: #9987 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
We have added a new command to renew cluster certificates using eksctl CLI. This PR adds documentation on how to use that command.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.