Add logic to discover edge connections in schema #1416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add EdgeConnection interface with edgeType, sourceLabel, targetLabel, count - Add edgeConnections field to Schema type - Extend SchemaResponse in connector with edgeConnections - Add createRandomEdgeConnection test utility - Add property test for edge connection serialization round-trip - Install fast-check for property-based testing
- Add edgeConnectionsTemplate.ts with Gremlin query for edge connections - Add fetchEdgeConnections function with multi-label support (:: separator) - Integrate edge connections into Gremlin schema response - Add property tests for splitGremlinLabels and expandEdgeConnections
…pher - Add edgeConnectionsTemplate.ts with OpenCypher query for edge connections - Add fetchEdgeConnections function with multi-label support (label arrays) - Use Zod schema for response validation - Integrate edge connections into OpenCypher schema response - Add property tests for expandEdgeConnections
- Fix Gremlin splitGremlinLabels test to exclude labels containing ':' - Add edge-connections.json mock file for Gremlin fetchSchema test - Update Gremlin fetchSchema test to include edge connections mock and expected output - Update OpenCypher fetchSchema tests to include edge connections mock - Update configuration.test.ts to expect undefined edgeConnections (task 6 pending) - Update globalMockFetch to include edge-connections.json mapping
- Add edgeConnections to SchemaInference type in schema.ts - Update mergeConfiguration to include edgeConnections from schema - Update saveConfigurationToFile to export edgeConnections - Update configuration.test.ts to verify edgeConnections are preserved Implements task 6: Update schema state management to handle edge connections - Task 6.1: Update schema state to store edge connections - Task 6.2: Update schema serialization for persistence - Task 6.3: Property test for serialization round-trip (already existed)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
===========================================
+ Coverage 47.81% 61.48% +13.67%
===========================================
Files 382 318 -64
Lines 8525 6528 -1997
Branches 3159 2280 -879
===========================================
- Hits 4076 4014 -62
+ Misses 3070 1764 -1306
+ Partials 1379 750 -629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Replaced by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validation
Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.