-
Notifications
You must be signed in to change notification settings - Fork 71
Add export button to Data Explorer #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is great @dwrth. I'm focused on other tasks, so I can't jump on this just yet. I think this is a small enough feature I can dedicate soon to review and test. |
|
In regards to this comment:
I don't think "Keep filtering and sorting" will ever make sense in this context. Since Data Explorer needs to work on server side paging/filtering/sorting then unchecking "Keep filtering and sorting" would imply that all nodes for the selected node type would be exported. I just don't think that is a realistic goal for any database of a reasonably large size (most users of Graph Explorer). So I think we will always want to export whatever is in the current view, which would essentially mean "Keep filtering and sorting" is always checked. |
|
Oh, and take a look at this PR: It is essentially removing that second nav bar in data explorer. So your new button will need to be moved to the |
|
@kmcginnes I merged the changes and moved the button to a new location. Also adjusted the export modal to hide the filter checkbox and force the 'only current page' checkbox |
kmcginnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally, and it looks pretty good. The main issue is hiding the "Only current page" option.
This will make the options list empty, so we should also hide the whole "Options" section.
The rest of my comments are cleanup and tests.
Description
This PR adds an export button to the Data Explorer and adjusts the helper functions in
transformToCsv.tsandtransformToJson.ts.Validation
Edit: new location of the export button
Related Issues
Resolves #1409
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.