Add data type descriptions to schema sidebar details#1533
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
===========================================
+ Coverage 47.81% 65.35% +17.53%
===========================================
Files 382 356 -26
Lines 8525 7960 -565
Branches 3159 2917 -242
===========================================
+ Hits 4076 5202 +1126
+ Misses 3070 1991 -1079
+ Partials 1379 767 -612
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arseny-kostenko
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the schema sidebar detail components to add descriptive headers, an empty state for properties, and shared layout primitives. Also adds a steering rule against testing styling/layout and includes behavioral tests for
PropertiesDetails.Details,DetailsHeader,DetailsDescriptionlayout components to reduce duplication acrossNodeLabelDetailsandEdgeConnectionDetailsAttributeListtoPropertiesDetailsand move the section title, count chip, description, and empty state handling into it so both panels get consistent behaviorDetailsTitlefromdivtoh2for better semanticsprimary-subtletoneutral-subtleDetails.tsxPropertiesDetailscovering empty state, populated list, attribute count, and description text.kiro/steering/testing.mdValidation
pnpm test)PropertiesDetails(4 tests)pnpm checks)Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.