Skip to content

fix: Handle rate limiting in validation controller#7892

Merged
edibble21 merged 4 commits intoaws:mainfrom
edibble21:validationcacheincrease
Mar 14, 2025
Merged

fix: Handle rate limiting in validation controller#7892
edibble21 merged 4 commits intoaws:mainfrom
edibble21:validationcacheincrease

Conversation

@edibble21
Copy link
Copy Markdown
Contributor

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner March 13, 2025 16:05
@edibble21 edibble21 requested a review from bwagner5 March 13, 2025 16:05
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 13, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4c0491e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67d4883cf0ee6f00088ac337

Copy link
Copy Markdown
Contributor Author

@edibble21 edibble21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Copy Markdown
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-eddc1bc0087c770a9b85df3434cf894e288ce002.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-eddc1bc0087c770a9b85df3434cf894e288ce002" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jonathan-innis
jonathan-innis previously approved these changes Mar 13, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 13, 2025

Pull Request Test Coverage Report for Build 13864258091

Details

  • 17 of 33 (51.52%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 67.078%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 1 0.0%
pkg/controllers/nodeclass/validation.go 12 19 63.16%
pkg/errors/errors.go 5 13 38.46%
Totals Coverage Status
Change from base Build 13847743506: -0.06%
Covered Lines: 6787
Relevant Lines: 10118

💛 - Coveralls

@edibble21 edibble21 force-pushed the validationcacheincrease branch from e8e5e42 to b278d73 Compare March 14, 2025 00:03
@edibble21 edibble21 changed the title fix: Increase validation cache fix: Handle rate limiting in validation controller Mar 14, 2025
Copy link
Copy Markdown
Contributor Author

@edibble21 edibble21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Copy Markdown
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-b278d739faa3d2ef40503cda5c0e974a7e83df08.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-b278d739faa3d2ef40503cda5c0e974a7e83df08" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@edibble21 edibble21 force-pushed the validationcacheincrease branch from b278d73 to 7336aa9 Compare March 14, 2025 17:47
Copy link
Copy Markdown
Contributor Author

@edibble21 edibble21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Copy Markdown
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-97e20f35e66af80f1ce5d92bfe5f1f7f963c96db.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-97e20f35e66af80f1ce5d92bfe5f1f7f963c96db" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@edibble21 edibble21 force-pushed the validationcacheincrease branch from 97e20f3 to 2c59be3 Compare March 14, 2025 19:48
Copy link
Copy Markdown
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edibble21 edibble21 merged commit bfdd629 into aws:main Mar 14, 2025
18 checks passed
edibble21 added a commit to edibble21/karpenter-provider-aws that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants