fix: Create a separate controller for generating availability/pricing metrics#7898
Merged
jonathan-innis merged 1 commit intoaws:mainfrom Mar 18, 2025
Merged
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
e42e584 to
2636fee
Compare
Pull Request Test Coverage Report for Build 13931262486Details
💛 - Coveralls |
42ac2e5 to
6e85fc4
Compare
6e85fc4 to
c5e1766
Compare
jonathan-innis
commented
Mar 17, 2025
Contributor
Author
jonathan-innis
left a comment
There was a problem hiding this comment.
/karpenter snapshot
Contributor
|
Snapshot successfully published to |
0b45f58 to
6e28c43
Compare
jonathan-innis
commented
Mar 17, 2025
Contributor
Author
jonathan-innis
left a comment
There was a problem hiding this comment.
/karpenter snapshot
Contributor
|
Snapshot successfully published to |
rschalo
reviewed
Mar 18, 2025
rschalo
reviewed
Mar 18, 2025
rschalo
reviewed
Mar 18, 2025
446236e to
8863fb1
Compare
rschalo
reviewed
Mar 18, 2025
2279bb2 to
2a3ae49
Compare
2a3ae49 to
5de23f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7758
Description
This updates our pricing and availability metrics to be generated by a separate controller. This controller polls every minute, pulls all NodePools on the cluster, and unions their results to generate the pricing and availability information globally.
Note that this now means that if no NodePool selects on a specific subnet through their referenced EC2NodeClasses, that that offering will now report as unavailable. Pricing data should be consistent across NodePools and will continue to be reported regardless if the offering is available or not.
How was this change tested?
make presubmit/karpenter snapshotDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.