chore: use strings.Builder and fmt.Appendf for… #8818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview deployment ready! Preview URL: https://pr-8818.d18coufmbnnaag.amplifyapp.com Built from commit |
Pull Request Test Coverage Report for Build 20678809604Details
💛 - Coveralls |
Contributor
|
Can you demonstrate that this does generates the strings properly after the change? |
Contributor
Author
I can add a unit test to verify this, but the only difference is performance - strings.Builder don't allocate a new string on each concatenation |
engedaam
approved these changes
Jan 10, 2026
saurav-agarwalla
pushed a commit
to saurav-agarwalla/karpenter-provider-aws
that referenced
this pull request
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
efficient string construction
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.