You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @DerekFrank, I've fixed the compilation errors in the latest commit. The issue was with the gomega API usage - I've updated it to use .WithContext(ctx) instead of passing the context as the first argument. Could you please re-trigger the CI when you get a chance? Thank you!
- Change gomega.Eventually(ctx, actual, intervals...) to
gomega.Eventually(actual, intervals...).WithContext(ctx)
- Change gomega.Consistently(ctx, actual, intervals...) to
gomega.Consistently(actual, intervals...).WithContext(ctx)
- Fix return type from ConsistentlyAssertion to AsyncAssertion
The previous syntax was not supported by the current gomega API.
FYI: the latest workflow runs (CI/CI-TEST/CodeQL/DryRunGenPR/WebsitePreviewTrigger) are in 'action_required' because this is a fork. Could a maintainer approve and re-run the workflows when convenient?
Hey @KyungHwanKim-devs, seems like the CI run is failing. I think you just need to run make presubmit and once you push the changes that might be generated from that file, all the CI should pass
Hi @engedaam thanks for the guidance. I ran make presubmit and pushed the missing license header for context_test.go. Could you approve and re-run the workflows when you have a chance? Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KyungHwanKim-devs
force-pushed
the
fix/scale-speccontext
branch
from
Fixes #5557
Description
Eventually/Consistentlythrough the active context.How was this change tested?
go test ./test/pkg/environment/common -run TestMergeContextsDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.