feat: Placement Group Support by joshuakguo · Pull Request #9030 · aws/karpenter-provider-aws

joshuakguo · 2026-03-23T23:11:48Z

Description

add support for configuring EC2 Placement Groups on the EC2NodeClass

spec:
  placementGroupSelector:
    name: string
    id: string

add node labels karpenter.k8s.aws/placement-group-id and karpenter.k8s.aws/placement-group-partition (only for partition placement groups) for instances launched in placement groups

How was this change tested?

unit tests
manual testing

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2026-03-23T23:15:07Z

Preview deployment ready!

Preview URL: https://pr-9030.d18coufmbnnaag.amplifyapp.com

Built from commit a76931bfa315cb9652bd11b3bc5b7289f7e7ab93

nathangeology

Placement groups a great feature to support. Left a few comments, I hope they are helpful!

pkg/providers/instancetype/offering/offering.go

pkg/apis/v1/ec2nodeclass.go

pkg/cloudprovider/registrationhooks/placementgrouphook.go

pkg/cloudprovider/cloudprovider.go

pkg/providers/placementgroup/provider.go

pkg/apis/v1/ec2nodeclass_status.go

joshuakguo

/karpenter snapshot

github-actions · 2026-03-27T23:45:07Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-190e85efc9d157df8a60bbe5da752f65be0764b3.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-190e85efc9d157df8a60bbe5da752f65be0764b3" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/providers/instancetype/offering/offering.go

designs/placement-groups-support.md

pkg/apis/v1/ec2nodeclass.go

pkg/apis/v1/ec2nodeclass_status.go

pkg/cache/unavailableofferings.go

pkg/cloudprovider/registrationhooks/placementgrouphook.go

pkg/providers/instance/instance.go

pkg/providers/instance/types.go

pkg/providers/launchtemplate/launchtemplate.go

shawnawshk · 2026-04-01T02:16:41Z

Hi team, looking forward to this feature release. Expect an ETA here

…e nodeclass status

pkg/apis/v1/ec2nodeclass.go

pkg/cloudprovider/registrationhooks/placementgrouphook.go

pkg/providers/placementgroup/provider.go

joshuakguo

/karpenter snapshot

github-actions · 2026-04-02T22:50:40Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d0f56154a02e86ea92427084c9e63c8e118bc34f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d0f56154a02e86ea92427084c9e63c8e118bc34f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/providers/placementgroup/provider.go

joshuakguo

/karpenter snapshot

github-actions · 2026-04-03T19:00:44Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-497d09a9671c40d6d54648544d0ddc9ab7730626.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-497d09a9671c40d6d54648544d0ddc9ab7730626" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

joshuakguo

/karpenter snapshot

github-actions · 2026-04-03T19:14:18Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-48fb4d6b209d6baa7340e8955fd37dcc5b85150c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-48fb4d6b209d6baa7340e8955fd37dcc5b85150c" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

joshuakguo

/karpenter snapshot

github-actions · 2026-04-03T21:29:15Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-7cb40c1e59e6223ba8af6c6c1935f4847dd8185e.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-7cb40c1e59e6223ba8af6c6c1935f4847dd8185e" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

joshuakguo

/karpenter snapshot

github-actions · 2026-04-04T09:11:20Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-a76931bfa315cb9652bd11b3bc5b7289f7e7ab93.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-a76931bfa315cb9652bd11b3bc5b7289f7e7ab93" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jmdeal

LGTM 🚀

hustshawn · 2026-04-07T01:53:57Z

Great job @joshuakguo , thank you

joshuakguo force-pushed the placement-groups-support branch from f23151b to 0421ea8 Compare March 24, 2026 20:33

nathangeology reviewed Mar 25, 2026

View reviewed changes

joshuakguo force-pushed the placement-groups-support branch 2 times, most recently from c44d044 to d0e24ad Compare March 26, 2026 01:25

jigisha620 reviewed Mar 26, 2026

View reviewed changes

joshuakguo force-pushed the placement-groups-support branch from d0e24ad to 190e85e Compare March 27, 2026 21:05

joshuakguo marked this pull request as ready for review March 27, 2026 21:25

joshuakguo requested a review from a team as a code owner March 27, 2026 21:25

joshuakguo requested a review from jigisha620 March 27, 2026 21:25

joshuakguo commented Mar 27, 2026

View reviewed changes

jigisha620 reviewed Mar 30, 2026

View reviewed changes

pkg/providers/instancetype/offering/offering.go Outdated Show resolved Hide resolved

jigisha620 reviewed Mar 30, 2026

View reviewed changes

designs/placement-groups-support.md Show resolved Hide resolved

joshuakguo force-pushed the placement-groups-support branch from 190e85e to 542c80a Compare March 31, 2026 01:06

jmdeal reviewed Mar 31, 2026

View reviewed changes

joshuakguo added 3 commits April 1, 2026 15:53

feat: Placement Group Support

8663350

refactor to store resolved placement group in memory instead of in th…

fa8da60

…e nodeclass status

address comments

f65d2ae

joshuakguo force-pushed the placement-groups-support branch from 43232d0 to f65d2ae Compare April 1, 2026 22:59

joshuakguo added 3 commits April 1, 2026 16:16

update interface

ec3211b

rfc update

e455c8d

more rfc updates

7b20f89

jmdeal self-assigned this Apr 2, 2026

jmdeal reviewed Apr 2, 2026

View reviewed changes

joshuakguo added 2 commits April 2, 2026 14:30

comments 2

6dacf5d

rfc updates

d0f5615

joshuakguo commented Apr 2, 2026

View reviewed changes

jmdeal reviewed Apr 3, 2026

View reviewed changes

pkg/providers/placementgroup/provider.go Show resolved Hide resolved

integ test

497d09a

joshuakguo commented Apr 3, 2026

View reviewed changes

comma fix

48fb4d6

joshuakguo commented Apr 3, 2026

View reviewed changes

karpenter mainline bump

7cb40c1

joshuakguo commented Apr 3, 2026

View reviewed changes

joshuakguo added 4 commits April 3, 2026 16:58

fix integ test

e32258b

integ test fix

74bcd24

scheduling fixes and more integ tests

ed1b0e2

re add strict

a76931b

joshuakguo commented Apr 4, 2026

View reviewed changes

jmdeal approved these changes Apr 6, 2026

View reviewed changes

joshuakguo merged commit edd18ec into aws:main Apr 6, 2026
30 of 31 checks passed

Conversation

joshuakguo commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nathangeology left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshuakguo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shawnawshk commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshuakguo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Uh oh!

joshuakguo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

joshuakguo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

joshuakguo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

joshuakguo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 4, 2026

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hustshawn commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

github-actions bot commented Mar 23, 2026 •

edited

Loading