You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: CI builds failing due to proxyquire incompatibility with Node.js 24 (#700)
## Problem
- CI builds were failing because the proxyquire library is not supported
in Node.js version 24, causing test failures in the webworker test
suite.
```
1 failing
1) webworker
"before each" hook for "should initialize lsp connection and start listening":
TypeError: Cannot read properties of undefined (reading 'require')
at Proxyquire.load (/home/runner/work/language-server-runtimes/language-server-runtimes/node_modules/proxyquire/lib/proxyquire.js:129:72)
at Context.<anonymous> (runtimes/webworker.test.ts:26:37)
at processImmediate (node:internal/timers:505:21)
```
## Solution
Test Refactoring (runtimes/runtimes/webworker.test.ts):
- Replaced proxyquire-based mocking with native ES6 dynamic imports
- Simplified test structure by removing complex proxyquire setup
- Updated test to use await import('./webworker') instead of proxyquire
<!---
REMINDER:
- Read CONTRIBUTING.md first.
- Add test coverage for your changes.
- Link to related issues/commits.
- Testing: how did you test your changes?
- Screenshots if applicable
-->
## License
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
0 commit comments