fix: support JSON Schema extension keywords and properly infer required fields#406
Merged
fix: support JSON Schema extension keywords and properly infer required fields#406
Conversation
kmile
force-pushed
the
kmile/agent-feature
branch
from
51534b0 to
39b8443
Compare
viktorsaws
approved these changes
Apr 2, 2025
jpinkney-aws
approved these changes
Apr 2, 2025
kmile
force-pushed
the
kmile/agent-feature
branch
from
39b8443 to
5ac632d
Compare
imykhai
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Bedrock JSON Schema allows any extension keyword to be defined, so we have to support a string indexer field.
When providing mixed required and non-required properties in JSON objects, they were not inferred properly.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.